Show both tooltips on hover when lollipop exists in both groups in comparison view lollipop #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Dec 22, 2022
packages/react-mutation-mapper/src/component/lollipopPlot/LollipopPlotNoTooltip.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Dec 22, 2022
packages/react-mutation-mapper/src/component/lollipopPlot/LollipopPlotNoTooltip.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Dec 22, 2022
| @@ -143,11 +145,26 @@ export default class LollipopPlotNoTooltip extends React.Component< | |||
| if (lollipopIndex !== null) { | |||
| const lollipopComponent = this.lollipopComponents[lollipopIndex]; | |||
| if (lollipopComponent) { | |||
| const mirrorLollipopComponent = _.find( | |||
There was a problem hiding this comment.
lets put a nice comment on this explaining concept of "mirror"
|
@gblaih nice work here! looks great. can you add some comments to this code explaining what "mirror" hitzone is? |
alisman
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature in cBioPortal/cbioportal#9901