Move driver annotation settings button to mutation filter panel in comparison view lollipop #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gblaih
force-pushed
the
group-comparison-lollipop-plot-settings-button
branch
from
1d54ec6 to
9897217
Compare
gblaih
force-pushed
the
group-comparison-lollipop-plot-settings-button
branch
from
9897217 to
874e759
Compare
alisman
reviewed
Jan 13, 2023
| style={{ | ||
| marginRight: 0, | ||
| marginLeft: 5, | ||
| if (this.props.inFilterPanel) { |
There was a problem hiding this comment.
what's difference between these two modes? hard for me to see.
There was a problem hiding this comment.
inFilterPanel refers to if the button is in the filter panel. In the comparison view, the button is in the filter panel as opposed to the results view where the button is on the top of the page by the "Modify Query" button. If it is in the panel, the button's properties are set so it is more suitable for the filter panel, like setting its trigger to click, its tooltip placement is from the top, the icon is smaller, styling, etc.
alisman
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves driver annotation settings button to mutation filter panel above protein impact type badges and hides button that appears on hover next to driver badge.
Related issue cBioPortal/cbioportal#9901