Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing react-bootstrap dependency for cbioportal-frontend-commons #4477

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add missing react-bootstrap dependency for cbioportal-frontend-commons #4477

merged 1 commit into from
Jan 11, 2023

Conversation

onursumer
Copy link
Member

This missing dependency might be causing the problem observed in this PR

@onursumer onursumer requested review from inodb and leexgh January 11, 2023 22:55
inodb
inodb approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onursumer onursumer added the automerge automerges with kodiak github app label Jan 11, 2023
@kodiakhq kodiakhq bot merged commit 44ecd56 into cBioPortal:master Jan 11, 2023
@onursumer onursumer deleted the add-missing-react-bootstrap branch January 12, 2023 00:13
@dippindots dippindots added the dependencies Pull requests that update a dependency file label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodb inodb inodb approved these changes

@leexgh leexgh Awaiting requested review from leexgh

Assignees
No one assigned
Labels
automerge automerges with kodiak github app dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onursumer @inodb @dippindots