Fix missing oncokb-frontend-commons dependency and styles #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can we prevent similar issue? |
@zhx828 I think we need an isolated test environment or something like that. Not sure what's the best practice to catch styling issues. |
alisman
approved these changes
Jan 13, 2023
|
Not related to this issue, but seems all cancer type is unknow in tooltip: |
Good catch! This issue might be specific to Signal since it already exists in the production. We should address this in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to knowledgesystems/signal#152 (comment)
Seems like oncokb-frontend-commons relies on some styles inherited from the
cbioportal-frontendcss class. Outside the cBioPortal context these styles do not exist and results in partially broken tooltip.