Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right Aligned numbers in study view #4539

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

aditygrg2
Copy link
Contributor

@aditygrg2 aditygrg2 commented Mar 7, 2023

Fix cBioPortal/cbioportal#10006

Sorry for accidentally closing the previous PR here #4537

Right-aligned text for numbers in MultiSelectionTable

  • Updated a CSS class 'pullRight' which when used now displays numeric data aligned to right in multiselection table exception being getFreqColumnRender() which takes style as one of its arguments, and there is no class argument, so we cannot use a class without changing the function.

@alisman
Copy link
Collaborator

alisman commented Mar 8, 2023

@aditygrg2 thanks for this PR! I just updates screenshots for end to end tests. i'll merge this pending the test passing

@@ -13,6 +13,7 @@ import {
} from 'pages/studyView/StudyViewUtils';
import { GenePanelList } from 'pages/studyView/table/StudyViewGenePanelModal';
import { CSSProperties } from 'react';
import { CSSTransitionClassNames } from 'react-transition-group/CSSTransition';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditygrg2 just noticed this. it's not used, right?

@alisman alisman merged commit bcd344b into cBioPortal:master Mar 8, 2023
@inodb inodb added the gsoc label Mar 9, 2023
@dippindots dippindots added the bug label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

right align all numbers on Study View
4 participants