Add revue icon for revue variants #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leexgh
changed the title
alisman
reviewed
Apr 27, 2023
alisman
reviewed
Apr 27, 2023
alisman
reviewed
Apr 27, 2023
alisman
reviewed
Apr 27, 2023
alisman
reviewed
Apr 27, 2023
src/rootImages/vue_logo.png
Outdated
There was a problem hiding this comment.
@alisman This is used in Annotation column header, the other is used in column components inside react-mutation-mapper package
alisman
reviewed
Apr 27, 2023
src/shared/components/mutationTable/column/MutationTypeColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Apr 27, 2023
src/shared/components/mutationTable/column/MutationTypeColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Apr 27, 2023
src/shared/components/mutationTable/column/ProteinChangeColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Apr 27, 2023
| ); | ||
| }; | ||
|
|
||
| export function sortValue(vue: Vues | undefined): number { |
There was a problem hiding this comment.
does this need to be exported?
There was a problem hiding this comment.
@alisman Yes it's used in /packages/react-mutation-mapper/src/component/column/Annotation.tsx
alisman
reviewed
Apr 27, 2023
packages/react-mutation-mapper/src/component/column/Annotation.tsx
Outdated
Show resolved
Hide resolved
onursumer
reviewed
Apr 27, 2023
src/shared/components/mutationTable/column/ProteinChangeColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: cBioPortal/cbioportal#9993
Testing:
https://deploy-preview-4589--cbioportalfrontend.netlify.app/results/mutations?cancer_study_list=msk_impact_2017&Z_SCORE_THRESHOLD=2.0&RPPA_SCORE_THRESHOLD=2.0&profileFilter=mutations%2Cstructural_variants%2Ccna&case_set_id=msk_impact_2017_cnaseq&gene_list=CTNNB1&geneset_list=%20&tab_index=tab_visualize&Action=Submit
Filter by
splice, reVUE variants are on the top of the table. ReVUE icon shows inprotein change,annotationandmutation typecolumn.ReVUE icon is hidden in
protein changeandmutation typecolumn, hover column cell shows reVUE icon.