Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Clinical Attribute Charts when priority is -1 #4598

Conversation

haynescd
Copy link
Contributor

@haynescd haynescd commented Apr 26, 2023

Fix cBioPortal/cbioportal#10133

Update chartMetaSet getter to ignore clinical Attribute charts when priority is < 0

  • Add LocalDB test (Attributes with priority of -1)
  • Test Priority of Session Service and how changes will react to saved charts

@haynescd haynescd self-assigned this Apr 26, 2023
@haynescd haynescd requested a review from alisman April 26, 2023 14:39
@inodb inodb requested a review from dippindots April 26, 2023 14:54
@haynescd haynescd force-pushed the feature/10133-Exclude-Clinical-Attributes-With-low-priority branch 2 times, most recently from a1fb90c to 4a87d07 Compare April 26, 2023 14:57
@dippindots
Copy link
Member

@inodb @haynescd I checked the public database and GENIE database, and we currently don't have any attributes that have a value of priority less than 0. So it should be fine to use -1 to remove the attribute.

Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's very straightforward. Just one more question regarding the clinical tab in the study view, are we also gonna hide those attributes from those columns too?

@haynescd
Copy link
Contributor Author

Ok, awesome. I am going to make a localdb update to add attributes with priority of -1 so I can test this feature.

@dippindots Are you talking about the clinical tab under "Add Chart" Button?

@dippindots
Copy link
Member

@haynescd For example, in this study: https://www.cbioportal.org/study/clinicalData?id=msk_impact_2017
Just wanted to know if we will also hide priority=-1 attributes in this table
image

@haynescd haynescd force-pushed the feature/10133-Exclude-Clinical-Attributes-With-low-priority branch from 4a87d07 to e88a918 Compare May 3, 2023 13:44
@haynescd haynescd merged commit 69c0d61 into cBioPortal:master May 3, 2023
@haynescd haynescd deleted the feature/10133-Exclude-Clinical-Attributes-With-low-priority branch June 28, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For clinical attributes with priority=-1, exclude them from add charts list
3 participants