Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide reVUE when there is no reVUE mutations in the query #4637

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

leexgh
Copy link
Member

@leexgh leexgh commented Jun 2, 2023

Fix: cBioPortal/cbioportal#10159

Only show reVUE when reVUE mutation exists.

Test:
Results view:
https://deploy-preview-4637--cbioportalfrontend.netlify.app/results/mutations?cancer_study_list=msk_impact_2017&Z_SCORE_THRESHOLD=2.0&RPPA_SCORE_THRESHOLD=2.0&profileFilter=mutations%2Cstructural_variants%2Ccna&case_set_id=msk_impact_2017_cnaseq&gene_list=TP53%2520CTNNB1&geneset_list=%20&tab_index=tab_visualize&Action=Submit&mutations_gene=TP53&mutations_transcript_id=ENST00000349496
Click TP53 and there is no reVUE, click CTNNB1 would show reVUE in annotation column.
The downloaded table for CTNNB1 includes reVUE while TP53 doesn't.

Patients view:
https://deploy-preview-4637--cbioportalfrontend.netlify.app/patient?sampleId=P-0003717-T01-IM5&studyId=msk_impact_2017
vs
https://deploy-preview-4637--cbioportalfrontend.netlify.app/patient?sampleId=P-0000212-T01-IM3&studyId=msk_impact_2017

Mutation mapper tool:

Sample_ID	Cancer_Type	Chromosome	Start_Position	End_Position	Reference_Allele	Variant_Allele
TCGA-49-4494-01	Lung Adenocarcinoma	7	55249071	55249071	C	T
TCGA-49-4494-01	Lung Adenocarcinoma	3	41266013	41266355	ATAGCTGATTTGATGGAGTTGGACATGGCCATGGAACCAGACAGAAAAGCGGCTGTTAGTCACTGGCAGCAACAGTCTTACCTGGACTCTGGAATCCATTCTGGTGCCACTACCACAGCTCCTTCTCTGAGTGGTAAAGGCAATCCTGAGGAAGAGGATGTGGATACCTCCCAAGTCCTGTATGAGTGGGAACAGGGATTTTCTCAGTCCTTCACTCAAGAACAAGTAGCTGGTAAGAGTATTATTTTTCATTGCCTTACTGAAAGTCAGAATGCAGTTTTGAGAACTAAAAAGTTAGTGTATAATAGTTTAAATAAAATGTTGTGGTGAAGAAAAGAGAGTA	-
image

vs

Sample_ID	Cancer_Type	Chromosome	Start_Position	End_Position	Reference_Allele	Variant_Allele
TCGA-49-4494-01	Lung Adenocarcinoma	7	55249071	55249071	C	T
image

@leexgh leexgh requested a review from inodb June 2, 2023 20:34
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leexgh LGTM! Thanks so much!

@inodb inodb merged commit e4fef0c into cBioPortal:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only show reVUE icon when a VUE exists
2 participants