-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable data download but still allow figure download #4662
Conversation
src/appShell/App/Container.tsx
Outdated
@@ -68,9 +69,27 @@ export default class Container extends React.Component<IContainerProps, {}> { | |||
} | |||
|
|||
get appContext(): IAppContext { | |||
const downloadConfig: string = getServerConfig() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kalletlak, will this be backward compatible? if they had it as false in portal.properties, it seems it would now default to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like not backward compatible. I'll discuss and let you know.
The context api is a legitimate way to do this but it departs from the usual way of accessing global settings loaded from server, which is getServerConfig(). I think since that's already established, we might as well keep using it. Let me know if you see a reason otherwise. |
You mean to replace context with getServerConfig() for |
@h164654156465 could you replace all occurrence with what's done at https://github.com/cBioPortal/cbioportal-frontend/pull/4662/files#diff-d04b96b830a44847891cea2270dce1679954330a355fb46488bebc9ae466179aR449 |
45d5783
to
2ace835
Compare
Support 'data' option and disable data download on Study page and Group Comparison page
2ace835
to
c306862
Compare
Fix cBioPortal/cbioportal#10180
Describe changes proposed in this pull request:
Related backend PR cBioPortal/cbioportal#10258