[RFC 76] Redesign oncoprint annotation menu #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasLee
changed the title
|
@BasLee could you move the custom driver tiers to be indented below the custom driver annotations? |
One of the points of this redesign was that many users did not understand that the Driver tiers mechanism is independent from the binary Custom Driver annotations mechanism. |
|
✔️ Align bottom 'only profiled' checkbox in 0023fa3 |
BasLee
force-pushed
the
restyle-oncoprint-annotation-menu
branch
2 times, most recently
from
0023fa3 to
3665e01
Compare
inodb
reviewed
Aug 30, 2023
BasLee
force-pushed
the
restyle-oncoprint-annotation-menu
branch
from
b05bf02 to
0f5d99f
Compare
SRodenburg
requested changes
Sep 5, 2023
| oncoprint.custom_driver_annotation.binary.menu_label=Custom driver annotation | ||
| oncoprint.custom_driver_annotation.tiers.menu_label=Custom driver tiers | ||
| oncoprint.custom_driver_annotation.binary.menu_label=Custom driver annotations | ||
| oncoprint.custom_driver_annotation.tiers.menu_label=Driver tiers |
There was a problem hiding this comment.
Suggested change
| oncoprint.custom_driver_annotation.tiers.menu_label=Driver tiers | |
| oncoprint.custom_driver_annotation.tiers.menu_label=Custom driver tiers |
There was a problem hiding this comment.
@pvannierop after our discussion with @inodb
Please follow up now that Bas is gone.
pvannierop
force-pushed
the
restyle-oncoprint-annotation-menu
branch
2 times, most recently
from
05c155b to
b8995a5
Compare
pvannierop
force-pushed
the
restyle-oncoprint-annotation-menu
branch
from
b8995a5 to
d4ad3c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign the oncoprint annotation menu as described in RFC 76.
Changes
Screenshot of restyled menu