Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginated download of data for Clinical Data tab in Study View #4786

Merged
merged 13 commits into from
May 7, 2024

Conversation

pvannierop
Copy link
Contributor

⚠️ This PR breaks the API. Should be merged together with the corresponding cbioportal PR

Background

  • At present all clinical data is downloaded the the user visits the Clinical Data tab on Study View. On large studies this results in a very long wait period before the user can interact with the data table.

Solution

  • This PR will implement paginated download of clinical table. A slice of 1000 sample records is retrieved which can be paginated locally.
  • Clinical Data is collected in the SampleClinicalDataCollection class where the data is keyed by the uniqueSampleKey (base64 encoded concatenation of sample and study identifier).

@pvannierop pvannierop self-assigned this Nov 29, 2023
@pvannierop pvannierop changed the title Clindata filter Paginated download of data for Clinical Data tab in Study View Nov 29, 2023
@pvannierop pvannierop marked this pull request as draft November 29, 2023 14:27
@pvannierop pvannierop marked this pull request as ready for review November 29, 2023 14:31
@inodb inodb requested a review from dippindots December 4, 2023 15:42
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 399651d
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/662abc0fa7ca8200089977f8
😎 Deploy Preview https://deploy-preview-4786--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dippindots dippindots merged commit 4642088 into cBioPortal:master May 7, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants