Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: data type filter set default value for checkbox #4804

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

TJMKuijpers
Copy link
Contributor

@TJMKuijpers TJMKuijpers commented Dec 18, 2023

Fix: Without the default value set for the checkbox of the data type filter menu, the state of the checkbox is remembered but the checkbox is not 'checked'.

Bug can be seen when a user filters on data type, select multiple studies and clicks on 'Query by Gene'. When the user clicks on 'modify' selected studies, the 'checked' checkbox is not blue.

@TJMKuijpers TJMKuijpers changed the title add default check for checkbox Fix: data type filter set default value for checkbox Dec 18, 2023
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@inodb inodb merged commit d68cbd7 into cBioPortal:master Dec 18, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants