Upgrade webdriver.io to v7 and begin migration of tests from sync to asyn #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
force-pushed
the
asyncTest
branch
3 times, most recently
from
260b956
to
5f26d9d
Compare
alisman
changed the title
alisman
force-pushed
the
asyncTest
branch
3 times, most recently
from
c59ff19
to
9083661
Compare
alisman
force-pushed
the
asyncTest
branch
3 times, most recently
from
2061fc4
to
da75381
Compare
onursumer
approved these changes
Apr 9, 2024
| - store_artifacts: | ||
| path: /tmp/repo/end-to-end-test/remote/junit/errors | ||
| path: /tmp/repo/end-to-end-test/local/junit/errors |
There was a problem hiding this comment.
were we storing the local artifacts in incorrect locations for all this time?
| @@ -633,7 +646,7 @@ describe('Group Comparison Tour', () => { | |||
| step++; | |||
| }); | |||
|
|
|||
| it('Step 8: Intro to the Survival tab, on the group comparison page.', () => { | |||
| it.skip('Step 8: Intro to the Survival tab, on the group comparison page.', () => { | |||
There was a problem hiding this comment.
are these skips intentional? do they stop working after upgrading to v7?
| checkBox.waitForExist({ timeout: 10000 }); | ||
| $('[data-test="StudySelect"] input').click(); | ||
| var input = await $('div[data-test=study-search] input[type=text]'); | ||
| await input.waitForExist({ timeout: 10000 }); |
There was a problem hiding this comment.
do we still need to call waitForExist? I was under the impression that await was already doing that.
|
|
||
| console.log('reportData', reportData); | ||
|
|
||
| var tests = _(reportData) |
There was a problem hiding this comment.
we don't seem to use this tests variable
|
|
||
| const filteredReportData = reportData.tests.filter(test => { | ||
| const de = deDupTests(reportData); |
| @@ -0,0 +1,830 @@ | |||
| const clipboardy = require('clipboardy'); | |||
There was a problem hiding this comment.
this is not entirely new, right? mostly copy of the existing specUtils.js?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to eventually upgrade to Webdriver.io 8, which will require we migrate our test style from sync to async per this documentation:
https://webdriver.io/docs/async-migration