Fixed png download for group comparison clinical data #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
reviewed
Apr 11, 2024
| ); | ||
|
|
||
| // parsing as SVGElement after css inlining | ||
| let parser = new DOMParser(); |
There was a problem hiding this comment.
how come we have to parse it back to SVG? is it just because saveMethod takes SVG?
There was a problem hiding this comment.
yeah exactly juice returns a string containing inlined html and saveMethod takes only SVGElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#10742
Describe changes proposed in this pull request:
Any screenshots or GIFs?
Before
before_png_bug_2.mp4
After
45879ab7-f04c-4c30-a269-80c6572bdb22.mp4
Notify reviewers
@inodb