-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LazyMobXTable countHeader when only has 1 page #4911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
force-pushed
the
fix-table-countheader
branch
from
May 10, 2024 16:46
66a9225
to
fc05fef
Compare
alisman
reviewed
May 10, 2024
gotcha. it's no biggie. lets just leave it.
…On Fri, May 10, 2024 at 2:45 PM Zhaoyuan (Ryan) Fu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/shared/components/lazyMobXTable/LazyMobXTable.tsx
<#4911 (comment)>
:
> @@ -1162,8 +1162,10 @@ export default class LazyMobXTable<T> extends React.Component<
fontWeight: 'bold',
}}
>
- {this.store.displayData.length} {this.store.itemsLabel} (page{' '}
- {this.store.page + 1} of {this.store.maxPage + 1})
+ {this.store.displayData.length} {this.store.itemsLabel}
+ {this.store.maxPage + 1 > 1 &&
Because in the latter part I saw this.store.maxPage + 1 and want to keep
the consistency. Do you think that makes sense or I can simplify it.
—
Reply to this email directly, view it on GitHub
<#4911 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNRGMTPAVPUL3IRNH2FHTZBUIVZAVCNFSM6AAAAABHQ2UJ3GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJQGY2TMNBRG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
alisman
force-pushed
the
fix-table-countheader
branch
from
May 23, 2024 17:56
9db05da
to
0f67399
Compare
alisman
force-pushed
the
fix-table-countheader
branch
from
May 24, 2024 16:52
a7d9d2b
to
5d030f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#10791
Describe changes proposed in this pull request: