Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LazyMobXTable countHeader when only has 1 page #4911

Merged
merged 6 commits into from
May 24, 2024

Conversation

fuzhaoyuan
Copy link
Contributor

Fix cBioPortal/cbioportal#10791

Describe changes proposed in this pull request:

  • Fix the behavior of LazyMobxTable when there is only 1 page, it should not display "(page 1 of 1)"

image

Copy link

netlify bot commented May 10, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 5d030f8
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/6650c5b866f42e00082d1c83
😎 Deploy Preview https://deploy-preview-4911--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fuzhaoyuan fuzhaoyuan requested a review from alisman May 10, 2024 15:34
@fuzhaoyuan fuzhaoyuan self-assigned this May 10, 2024
@alisman alisman force-pushed the fix-table-countheader branch from 66a9225 to fc05fef Compare May 10, 2024 16:46
@alisman
Copy link
Collaborator

alisman commented May 10, 2024 via email

@inodb inodb added the bug label May 16, 2024
@alisman alisman force-pushed the fix-table-countheader branch from 9db05da to 0f67399 Compare May 23, 2024 17:56
@alisman alisman force-pushed the fix-table-countheader branch from a7d9d2b to 5d030f8 Compare May 24, 2024 16:52
@alisman alisman merged commit 20cf5ad into cBioPortal:master May 24, 2024
2 of 3 checks passed
@fuzhaoyuan fuzhaoyuan deleted the fix-table-countheader branch November 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table should not display pagination counts when there is only one page
3 participants