Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swapping generic assay profiles in comparison view #4922

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix swapping generic assay profiles in comparison view #4922

merged 2 commits into from
Jul 1, 2024

Conversation

MatthijsPon
Copy link
Contributor

@MatthijsPon MatthijsPon commented Jun 12, 2024 •
edited
Loading

Fix cBioPortal/cbioportal#10520

Describe changes proposed in this pull request:

  • A previous PR forgot to change some variable names to the new naming, this fixes the leftovers

Compare swapping data sets on the following pages:

@MatthijsPon MatthijsPon self-assigned this Jun 12, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 25fc31c
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/667e77bcbd48fb0008c187f3
😎 Deploy Preview https://deploy-preview-4922--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatthijsPon MatthijsPon requested review from inodb and TJMKuijpers June 14, 2024 09:58
@MatthijsPon
Copy link
Contributor Author

MatthijsPon commented Jun 14, 2024 •
edited
Loading

It seems the failing tests are in all PRs and is not caused by my PR?

@MatthijsPon MatthijsPon requested review from dippindots and removed request for inodb June 17, 2024 09:52
TJMKuijpers
TJMKuijpers reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@TJMKuijpers TJMKuijpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to check if we can remove selectedGenericAssayEnrichmentProfileMapGroupedByGenericAssayType from the source code if it is not being used anymore. (code cleanup)

src/shared/lib/comparison/ComparisonStore.ts Show resolved Hide resolved
dippindots
dippindots reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. e2e tests are not running for some reason, we might want to see the tests passing before we merge it

src/shared/lib/comparison/ComparisonStore.ts Show resolved Hide resolved
dippindots
dippindots approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the code, LGTM

@inodb inodb merged commit b14bcf0 into cBioPortal:master Jul 1, 2024
13 of 15 checks passed
@inodb
Copy link
Member

inodb commented Jul 1, 2024

Thanks @MatthijsPon and @TJMKuijpers !

@MatthijsPon MatthijsPon deleted the fix_ga_profile_switch branch September 2, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TJMKuijpers TJMKuijpers TJMKuijpers left review comments

@dippindots dippindots dippindots approved these changes

Assignees

@MatthijsPon MatthijsPon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResultsView Comparison: Switching Generic Assay profiles does not update data
4 participants
@MatthijsPon @inodb @dippindots @TJMKuijpers