RFC83: Make virtual study available for all users on their landing pages #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
|
@alisman Hi! Could you please provide some guidance on which tests I should write for this PR? |
forus
changed the title
pieterlukasse
approved these changes
Jul 4, 2024
| @@ -17,6 +17,14 @@ export default class sessionServiceAPI { | |||
| return `${getSessionUrl()}/virtual_study`; | |||
| } | |||
|
|
|||
| getPublicVirtualStudyServiceUrl() { | |||
| //FIXME change url after moving the code to the session controller | |||
There was a problem hiding this comment.
Yes, here it is 2aea3c5
| //map public virtual study to cancer study | ||
| const _publicVirtualStudies = publicVirtualStudies | ||
| .map(publicVirtualStudy => { | ||
| // TODO: temp fix for when virtual study data is not of expeceted format |
There was a problem hiding this comment.
will this be added or is it a separate ticket?
There was a problem hiding this comment.
nea, let's just clean it. 2ac225d
| @@ -14,6 +14,7 @@ import { FilteredCancerTreeView } from '../StudyListLogic'; | |||
| import { | |||
| CancerTreeNode, | |||
| CancerTypeWithVisibility, | |||
| PUBLIC_VIRTUAL_STUDY_NAME, | |||
alisman
approved these changes
Jul 18, 2024
Parametrise public vs url instead of replacing it in a result url
Public VS functionality won't even work for legacy VS json format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Backend cBioPortal/cbioportal#10829
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR