Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutational sig bug #4930

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Conversation

TJMKuijpers
Copy link
Contributor

@TJMKuijpers TJMKuijpers commented Jun 24, 2024

Fix cBioPortal/cbioportal#10538. This is a fix for studies when only mutational signatures contribution and p-values are loaded (and no mutational signatures count data):
For a study without mutational signatures count data:

For a study with mutational signatures count data:

@TJMKuijpers TJMKuijpers self-assigned this Jun 24, 2024
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 0101bf1
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/6685634401afc5000795f4bc
😎 Deploy Preview https://deploy-preview-4930--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TJMKuijpers TJMKuijpers force-pushed the fix-mutational-sig-bug branch 2 times, most recently from 9e62da9 to 664f9eb Compare June 28, 2024 13:51
Show table when only contribution data is present
Merged with the hackathon improvements

fix merge error

update url and description
@inodb
Copy link
Member

inodb commented Jul 1, 2024

@TJMKuijpers thanks so much for this fix! Looks like there's a failing unit test

@inodb inodb marked this pull request as ready for review July 3, 2024 22:59
@inodb inodb merged commit 0ab0f9b into cBioPortal:master Jul 3, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutational signatures broken
3 participants