-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC87: add button to load GroupComparison table data in external tool #4938
Merged
Commits on Jul 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b24a2a0 - Browse repository at this point
Copy the full SHA b24a2a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2adbe74 - Browse repository at this point
Copy the full SHA 2adbe74View commit details -
- added margin to seperate tool section from section header. - made clear for "Windows" and visible
Configuration menu - View commit details
-
Copy full SHA for 67de804 - Browse repository at this point
Copy the full SHA 67de804View commit details -
- icon - display, copying standard button - style - WIP: not config driven and always appears
Configuration menu - View commit details
-
Copy full SHA for 62c76ee - Browse repository at this point
Copy the full SHA 62c76eeView commit details -
- ExternalToolConfig.ts to localize in one place - IAppConfig.external_tools: pull in type definition - serverConfigDefaults: pull in default
Configuration menu - View commit details
-
Copy full SHA for 460c0e6 - Browse repository at this point
Copy the full SHA 460c0e6View commit details -
- changed to be config-driven - support array - removed local image and pull from URL (avoids relative path)
Configuration menu - View commit details
-
Copy full SHA for 1741ab5 - Browse repository at this point
Copy the full SHA 1741ab5View commit details -
- renamed files to match folder (camelCase) - handleDownloadWrapper WIP - shrunk icon to be closer to the other
Configuration menu - View commit details
-
Copy full SHA for 91f3829 - Browse repository at this point
Copy the full SHA 91f3829View commit details -
- change to class - rename folder to match convention - moved render() out of CopyDownloadButtons - changed CopyDownloadControls to pass along the downloadData instead of handleDownload to give tool control - restored local icon so not dependent on external
Configuration menu - View commit details
-
Copy full SHA for 4585630 - Browse repository at this point
Copy the full SHA 4585630View commit details -
- iconImageSrc local fixed - have to use require() - put urlFormat parameters in a new object
Configuration menu - View commit details
-
Copy full SHA for e083f4e - Browse repository at this point
Copy the full SHA e083f4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2abf250 - Browse repository at this point
Copy the full SHA 2abf250View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f2bb30 - Browse repository at this point
Copy the full SHA 0f2bb30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ac61f2 - Browse repository at this point
Copy the full SHA 4ac61f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4da2f2e - Browse repository at this point
Copy the full SHA 4da2f2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5ed2b1 - Browse repository at this point
Copy the full SHA b5ed2b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1daa11 - Browse repository at this point
Copy the full SHA c1daa11View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8bda41 - Browse repository at this point
Copy the full SHA f8bda41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57d363c - Browse repository at this point
Copy the full SHA 57d363cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0620a93 - Browse repository at this point
Copy the full SHA 0620a93View commit details -
- mock clipboard - mock navigation - changed function references to functions for jest - fixed urlParameters indexing complaints
Configuration menu - View commit details
-
Copy full SHA for 50a9e11 - Browse repository at this point
Copy the full SHA 50a9e11View commit details -
- isAvailable check - required_platform - added fontdetect - localStorage caching
Configuration menu - View commit details
-
Copy full SHA for 3e4521e - Browse repository at this point
Copy the full SHA 3e4521eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3e9586 - Browse repository at this point
Copy the full SHA f3e9586View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60c1cd8 - Browse repository at this point
Copy the full SHA 60c1cd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d45e3d - Browse repository at this point
Copy the full SHA 9d45e3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f36462e - Browse repository at this point
Copy the full SHA f36462eView commit details -
Configuration menu - View commit details
-
Copy full SHA for de07ab7 - Browse repository at this point
Copy the full SHA de07ab7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b94143 - Browse repository at this point
Copy the full SHA 7b94143View commit details -
- changed to launch url with open() so uses new tab - add alert() if opening URL fails (probably won't happen) - added Test Tool to config - fixed showing multiple <ExternalTool>
Configuration menu - View commit details
-
Copy full SHA for 09e77c8 - Browse repository at this point
Copy the full SHA 09e77c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e0a0f6 - Browse repository at this point
Copy the full SHA 5e0a0f6View commit details
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 505ae08 - Browse repository at this point
Copy the full SHA 505ae08View commit details
Commits on Jul 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0023879 - Browse repository at this point
Copy the full SHA 0023879View commit details
Commits on Jul 25, 2024
-
GroupComparisonStore: revert Visualize: remove WIP block comment
Configuration menu - View commit details
-
Copy full SHA for a69aad2 - Browse repository at this point
Copy the full SHA a69aad2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16dfc0b - Browse repository at this point
Copy the full SHA 16dfc0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aea197d - Browse repository at this point
Copy the full SHA aea197dView commit details
Commits on Jul 29, 2024
-
CustomButton: rename component to be more general
- CustomButton: renamed files/types from ExternalTool - Config: changed to class and expose isAvailable(). Changed references to type to use new interface ICustomButtonConfig - removed image
Configuration menu - View commit details
-
Copy full SHA for 849c78e - Browse repository at this point
Copy the full SHA 849c78eView commit details -
- change usage to ICustomButtonConfig - renamed serverConfig prop to custom_buttons - report when downloadData not defined - renamed handleLaunchReady to openUrl - Config: updated image
Configuration menu - View commit details
-
Copy full SHA for ac59ef1 - Browse repository at this point
Copy the full SHA ac59ef1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 948c705 - Browse repository at this point
Copy the full SHA 948c705View commit details -
CustomButton: fixed async context
- downloadData: changed to Promise<string> so works in async use cases - TECH: had to update CopyDownloadControls and SimplyCopyDownloadControls to conform to the oine signature - Config: renamed image_src to match naming style
Configuration menu - View commit details
-
Copy full SHA for ae1c026 - Browse repository at this point
Copy the full SHA ae1c026View commit details -
Configuration menu - View commit details
-
Copy full SHA for 750952c - Browse repository at this point
Copy the full SHA 750952cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd91ee6 - Browse repository at this point
Copy the full SHA dd91ee6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e16fcf - Browse repository at this point
Copy the full SHA 0e16fcfView commit details
Commits on Jul 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4bba213 - Browse repository at this point
Copy the full SHA 4bba213View commit details -
Visualize: update 3rd party tools section
- added customToolArray style based on toolArray - it is double-width. This also makes layout horizontal to be consistent with toolArray.
Configuration menu - View commit details
-
Copy full SHA for 6048673 - Browse repository at this point
Copy the full SHA 6048673View commit details -
CustomButtonsConfig: change to pull from server
- changed config to a json string - added initialization/parsing to new lazy init getCustomButtonConfigs() - removed from serverConfigDefaults - removed baked in default objects - CLEANUP: fixed one var to const
Configuration menu - View commit details
-
Copy full SHA for 125636c - Browse repository at this point
Copy the full SHA 125636cView commit details -
- test parsing - test parses as correct object - fixed clipboard test
Configuration menu - View commit details
-
Copy full SHA for 3770159 - Browse repository at this point
Copy the full SHA 3770159View commit details -
CustomButtonConfig initialization
- moved getServerConfig() dependency to a new file to fix dependency issue with tests - removing unnecessary imports
Configuration menu - View commit details
-
Copy full SHA for 9f608e9 - Browse repository at this point
Copy the full SHA 9f608e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9b6e8d - Browse repository at this point
Copy the full SHA c9b6e8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81d5094 - Browse repository at this point
Copy the full SHA 81d5094View commit details
Commits on Jul 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b4b55a2 - Browse repository at this point
Copy the full SHA b4b55a2View commit details -
CustomButton URL Parsing: changed to "{var}" pattern from "${var}" pa…
…ttern EXPL: the "$" complicates parsing when running in JS.
Configuration menu - View commit details
-
Copy full SHA for d656ef9 - Browse repository at this point
Copy the full SHA d656ef9View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfadb72 - Browse repository at this point
Copy the full SHA cfadb72View commit details -
CustomButtonsConfig: stability
- fix one leftover old term - fixed CustomButtonConfig to catch all interface properties
Configuration menu - View commit details
-
Copy full SHA for d77a122 - Browse repository at this point
Copy the full SHA d77a122View commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 097f2cf - Browse repository at this point
Copy the full SHA 097f2cfView commit details
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aceef8e - Browse repository at this point
Copy the full SHA aceef8eView commit details -
- renamed ICopyDownloadControls and ICustomButton property downloadDataAsync to be clear is async - fixed downloadDataAsPromise() to not run downloadData() until resolved
Configuration menu - View commit details
-
Copy full SHA for 52a7af5 - Browse repository at this point
Copy the full SHA 52a7af5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca33254 - Browse repository at this point
Copy the full SHA ca33254View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3014aea - Browse repository at this point
Copy the full SHA 3014aeaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.