Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC87: add button to load GroupComparison table data in external tool #4938

Merged
merged 56 commits into from
Aug 13, 2024

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    b24a2a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2adbe74 View commit details
    Browse the repository at this point in the history
  3. Visualize - External Tools:

    - added margin to seperate tool section from section header.
    - made clear for "Windows" and visible
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    67de804 View commit details
    Browse the repository at this point in the history
  4. Download Button: WIP

    - icon
    - display, copying standard button
    - style
    - WIP: not config driven and always appears
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    62c76ee View commit details
    Browse the repository at this point in the history
  5. ExternalTools:

    - ExternalToolConfig.ts to localize in one place
    - IAppConfig.external_tools: pull in type definition
    - serverConfigDefaults: pull in default
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    460c0e6 View commit details
    Browse the repository at this point in the history
  6. Download Button:

    - changed to be config-driven
    - support array
    - removed local image and pull from URL (avoids relative path)
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1741ab5 View commit details
    Browse the repository at this point in the history
  7. External Tools:

    - renamed files to match folder (camelCase)
    - handleDownloadWrapper WIP
    - shrunk icon to be closer to the other
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    91f3829 View commit details
    Browse the repository at this point in the history
  8. + ExternalTools:

    - change to class
    - rename folder to match convention
    - moved render() out of CopyDownloadButtons
    - changed CopyDownloadControls to pass along the downloadData instead of handleDownload to give tool control
    - restored local icon so not dependent on external
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4585630 View commit details
    Browse the repository at this point in the history
  9. + ExternalTools:

    - iconImageSrc local fixed - have to use require()
    - put urlFormat parameters in a new object
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e083f4e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2abf250 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0f2bb30 View commit details
    Browse the repository at this point in the history
  12. External Tools:

    - cleanup
    - use clipboard
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4ac61f2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4da2f2e View commit details
    Browse the repository at this point in the history
  14. ExternalTool: cleanup

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b5ed2b1 View commit details
    Browse the repository at this point in the history
  15. ExternalTool:

    - dataLength validation
    - getSingleStudyName
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c1daa11 View commit details
    Browse the repository at this point in the history
  16. ExternalTool: cleanup

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f8bda41 View commit details
    Browse the repository at this point in the history
  17. ExternalTool: PrettierJS

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    57d363c View commit details
    Browse the repository at this point in the history
  18. ExternalTool: tests WIP

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0620a93 View commit details
    Browse the repository at this point in the history
  19. External Tool: tests working

    - mock clipboard
    - mock navigation
    - changed function references to functions for jest
    - fixed urlParameters indexing complaints
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    50a9e11 View commit details
    Browse the repository at this point in the history
  20. ExternalTool:

    - isAvailable check
    - required_platform
    - added fontdetect
    - localStorage caching
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3e4521e View commit details
    Browse the repository at this point in the history
  21. ExternalToolConfig tests

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f3e9586 View commit details
    Browse the repository at this point in the history
  22. FontDetector: refactored to TS

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    60c1cd8 View commit details
    Browse the repository at this point in the history
  23. FontDetector: WIP tests

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9d45e3d View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    f36462e View commit details
    Browse the repository at this point in the history
  25. ExternalTool: cleanup

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    de07ab7 View commit details
    Browse the repository at this point in the history
  26. PrettierJS

    Removed unnecessary imports
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    7b94143 View commit details
    Browse the repository at this point in the history
  27. ExternalTool:

    - changed to launch url with open() so uses new tab
    - add alert() if opening URL fails (probably won't happen)
    - added Test Tool to config
    - fixed showing multiple <ExternalTool>
    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    09e77c8 View commit details
    Browse the repository at this point in the history
  28. PrettierJS

    pappde committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5e0a0f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    505ae08 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    0023879 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Reducing code impact of PR

    GroupComparisonStore: revert
    Visualize: remove WIP block comment
    pappde committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a69aad2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    16dfc0b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aea197d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. CustomButton: rename component to be more general

    - CustomButton: renamed files/types from ExternalTool
    - Config: changed to class and expose isAvailable(). Changed references to type to use new interface ICustomButtonConfig
    - removed image
    pappde committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    849c78e View commit details
    Browse the repository at this point in the history
  2. CustomButton

    - change usage to ICustomButtonConfig
    - renamed serverConfig prop to custom_buttons
    - report when downloadData not defined
    - renamed handleLaunchReady to openUrl
    - Config: updated image
    pappde committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    ac59ef1 View commit details
    Browse the repository at this point in the history
  3. PrettierJS

    pappde committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    948c705 View commit details
    Browse the repository at this point in the history
  4. CustomButton: fixed async context

    - downloadData: changed to Promise<string> so works in async use cases
    - TECH: had to update CopyDownloadControls and SimplyCopyDownloadControls to conform to the oine signature
    - Config: renamed image_src to match naming style
    pappde committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    ae1c026 View commit details
    Browse the repository at this point in the history
  5. Comments

    pappde committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    750952c View commit details
    Browse the repository at this point in the history
  6. PrettierJS

    pappde committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    dd91ee6 View commit details
    Browse the repository at this point in the history
  7. Cleanup

    pappde committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0e16fcf View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Configuration menu
    Copy the full SHA
    4bba213 View commit details
    Browse the repository at this point in the history
  2. Visualize: update 3rd party tools section

    - added customToolArray style based on toolArray - it is double-width. This also makes layout  horizontal to be consistent with toolArray.
    pappde committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6048673 View commit details
    Browse the repository at this point in the history
  3. CustomButtonsConfig: change to pull from server

    - changed config to a json string
    - added initialization/parsing to new lazy init getCustomButtonConfigs()
    - removed from serverConfigDefaults
    - removed baked in default objects
    - CLEANUP: fixed one var to const
    pappde committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    125636c View commit details
    Browse the repository at this point in the history
  4. ConfigButton Tests

    - test parsing
    - test parses as correct object
    - fixed clipboard test
    pappde committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3770159 View commit details
    Browse the repository at this point in the history
  5. CustomButtonConfig initialization

    - moved getServerConfig() dependency to a new file to fix dependency issue with tests
    - removing unnecessary imports
    pappde committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9f608e9 View commit details
    Browse the repository at this point in the history
  6. CustomButtonConfig: fixed creating proper object types

    - fixes test
    pappde committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c9b6e8d View commit details
    Browse the repository at this point in the history
  7. PrettierJS

    pappde committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    81d5094 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Cleanup

    - comment update
    - removed image now stored in CDN
    pappde committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b4b55a2 View commit details
    Browse the repository at this point in the history
  2. CustomButton URL Parsing: changed to "{var}" pattern from "${var}" pa…

    …ttern
    
    EXPL: the "$" complicates parsing when running in JS.
    pappde committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    d656ef9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfadb72 View commit details
    Browse the repository at this point in the history
  4. CustomButtonsConfig: stability

    - fix one leftover old term
    - fixed CustomButtonConfig to catch all interface properties
    pappde committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    d77a122 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    097f2cf View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. PrettierFix

    pappde committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    aceef8e View commit details
    Browse the repository at this point in the history
  2. fixed downloadData unit test

    - renamed ICopyDownloadControls and ICustomButton property downloadDataAsync to be clear is async
    - fixed downloadDataAsPromise() to not run downloadData() until resolved
    pappde committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    52a7af5 View commit details
    Browse the repository at this point in the history
  3. PrettierFix

    pappde committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ca33254 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3014aea View commit details
    Browse the repository at this point in the history