Display geneUI on Row Hover Instead of geneSymbol Hover #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue #10762
Summary
This PR modifies the behavior of the
geneUIcomponent, ensuring it is displayed only when hovering over the entire row (.row) rather than just thegeneSymbolelement. This change enhances the user experience by making thegeneUIvisibility consistent across the entire row.Changes Made
CSS Adjustments:
.addGeneUIfrom.geneSymbol:hoverto.row:hover..geneSymbolthat controlled the visibility of.addGeneUI.Updated Selectors:
%addGeneUIHovermixin to.addGeneUIwithin the.row:hovercontext.Issue Resolution
The issue was resolved by ensuring the
geneUIcomponent becomes visible only when hovering over the.rowelement, rather than when hovering over the.geneSymbolelement. This change required adjusting the CSS selectors and hover states to target the entire row.Related Issue
Link to related issue
Testing and Verification
geneUIappears when hovering over any part of the row and not just thegeneSymbol.geneUImaintains proper styling and functionality when hovered and selected.Please review the changes and let me know if any further adjustments are needed.