Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix localStorage.frontendConfig being clobbered when localhost:3000 testing #4955

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

pappde
Copy link
Contributor

@pappde pappde commented Jul 31, 2024

Issue Fixed

When testing with localhost:3000, if you are manually setting "localStorage.frontendConfig" via the browser console, it gets clobbered by some test code in my-index.ejs.

Change

Removed (commented out) the test code.

Notify reviewers

@alisman

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 9c9190b
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/66aa7e6cc9ee970008091c98
😎 Deploy Preview https://deploy-preview-4955--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisman alisman merged commit dcae06d into cBioPortal:master Aug 12, 2024
13 of 15 checks passed
@dippindots dippindots added the chore This PR is related to code maintenance label Aug 13, 2024
Nelliney pushed a commit to Nelliney/cbioportal-frontend that referenced this pull request Aug 14, 2024
…esting (cBioPortal#4955)

Co-authored-by: Denis Papp <pappde@users.noreply.github.com>
Nelliney pushed a commit to Nelliney/cbioportal-frontend that referenced this pull request Aug 14, 2024
…esting (cBioPortal#4955)

Co-authored-by: Denis Papp <pappde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This PR is related to code maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants