Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organoid icon and color on Patient View #4963

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

inodb
Copy link
Member

@inodb inodb commented Aug 14, 2024

Add an organoid icon and color for samples of SAMPLE_CLASS === "Organoid" on the patient view:

image

Minor refactoring:

  • Import Icons as SVG, so one can directly edit the SVG in e.g. Illustrator (rather than having to mess around with functions). Not sure if it's ok to disable typing of SVGs? Seems like we do that in e.g. the OncoKB package, but not in the main package. Can use requires() as alternative

See preview

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 67fb36b
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/66be1c1746bb490009d48a92
😎 Deploy Preview https://deploy-preview-4963--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inodb inodb requested a review from onursumer August 14, 2024 21:38
@inodb inodb changed the title Add Organoid icon on Patient View Add Organoid icon and sample color on Patient View Aug 14, 2024
@inodb inodb changed the title Add Organoid icon and sample color on Patient View Add Organoid Icon and Sample Color on Patient View Aug 14, 2024
@inodb inodb changed the title Add Organoid Icon and Sample Color on Patient View Add organoid icon and sample color on Patient View Aug 14, 2024
@inodb inodb changed the title Add organoid icon and sample color on Patient View Add organoid icon and color on Patient View Aug 14, 2024
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@inodb inodb merged commit 9937567 into cBioPortal:master Aug 15, 2024
6 of 7 checks passed
@inodb inodb deleted the add-organoid-icon branch August 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants