Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refinements to jupyter modal #10949 #4968

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Refinements to jupyter modal #10949 #4968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bdd550
Refinements to the Jupyter modal. Closes #10949
gautamsarawagi Aug 19, 2024
ce9b799
Renamed Session to Notebook. Closes #10949
gautamsarawagi Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/pages/staticPages/tools/oncoprinter/JupyterNotebookModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,11 @@ class JupyterNoteBookModal extends React.Component<
return (
<Modal show={show} onHide={handleClose}>
<Modal.Header closeButton>
<Modal.Title>Enter Session Name</Modal.Title>
<Modal.Title>Enter Notebook Name</Modal.Title>
</Modal.Header>
<Modal.Body>
<Form
id="jupyterform"
onSubmit={e =>
this.handleSubmit(
(e as unknown) as React.FormEvent<
Expand All @@ -113,11 +114,11 @@ class JupyterNoteBookModal extends React.Component<
>
<FormGroup controlId="formFolderName">
<ControlLabel className="py-2">
Session Name
Notebook Name
</ControlLabel>
<FormControl
type="text"
placeholder="Enter Session Name"
placeholder="Enter Notebook Name"
value={folderName}
onChange={e =>
this.handleChange(
Expand All @@ -134,12 +135,14 @@ class JupyterNoteBookModal extends React.Component<
</div>
)}
</FormGroup>
<Modal.Footer>
<Button onClick={handleClose}>Close</Button>
<Button type="submit">Open Jupyter Notebook</Button>
</Modal.Footer>
</Form>
</Modal.Body>
<Modal.Footer>
<Button onClick={handleClose}>Close</Button>
<Button type="submit" form="jupyterform">
Open Jupyter Notebook
</Button>
</Modal.Footer>
</Modal>
);
}
Expand Down
Loading