Reduce api calls for generic assay meta in study view page #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dippindots
commented
Oct 11, 2024
| this.genericAssayProfiles.result | ||
| ); | ||
| }, | ||
| }); | ||
|
|
||
| readonly genericAssayStableIdToMeta = remoteData<{ |
There was a problem hiding this comment.
No reference, deleting this function
dippindots
force-pushed
the
generic-assay-meta-study-view-reduce-call
branch
3 times, most recently
from
b7d4fa5 to
2b27301
Compare
dippindots
force-pushed
the
generic-assay-meta-study-view-reduce-call
branch
from
2b27301 to
73f2ebe
Compare
alisman
force-pushed
the
clickhouse
branch
2 times, most recently
from
ecba99f to
22501dd
Compare
alisman
force-pushed
the
clickhouse
branch
2 times, most recently
from
55bfd57 to
59d0cf5
Compare
alisman
force-pushed
the
generic-assay-meta-study-view-reduce-call
branch
from
73f2ebe to
01a22a3
Compare
alisman
force-pushed
the
generic-assay-meta-study-view-reduce-call
branch
from
01a22a3 to
15e5c29
Compare
olzhasmukayev
pushed a commit
to olzhasmukayev/cbioportal-frontend
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unnecessarily firing generic assay meta requests for each ga entity when these could be batched (as in achieved in this PR).