Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Study View) Cancer studies chart filter refactoring #5031

Draft
wants to merge 49 commits into
base: clickhouse
Choose a base branch
from

Conversation

dippindots
Copy link
Member

Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • a
  • b

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

alisman and others added 30 commits June 12, 2024 10:59
Adjust patient treatments and sample treatments to use new treatment-counts api endoint (clickhouse driven)
* Add rfc80 test generator UI and test runner
* fix production build after webpack.config changes
* fix has generation based on url

* add back all endpoints
…#4981)

* add tests for sample lists counts and custom data filters
* add tests for custom data bin counts

---------

Co-authored-by: Bryan Lai <laib1@mskcc.org>
* improvements to apiTests reporting

* add skips to validation, refine report

* skip test

* improve report

* Move api e2e to backend
@dippindots dippindots self-assigned this Oct 23, 2024
@alisman alisman requested a review from onursumer November 12, 2024 16:57
@onursumer
Copy link
Member

For certain filter combinations the new version ends up with way more number of samples than it is supposed to.

Before (31 patients / 31 samples):
before 2studies+1gene

After (401 patients / 409 samples):
after 2studies+1gene

For some reason the new code generates a wrong filter object by including all the studies instead of the selected two only:

Screen Shot 2024-11-12 at 5 01 39 PM

@alisman
Copy link
Collaborator

alisman commented Nov 13, 2024

@dippindots just wanted to make sure you saw the above

@onursumer onursumer self-assigned this Nov 13, 2024
@alisman alisman force-pushed the clickhouse branch 2 times, most recently from ecba99f to 22501dd Compare November 25, 2024 19:34
@alisman alisman force-pushed the clickhouse branch 2 times, most recently from 55bfd57 to 59d0cf5 Compare December 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants