-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Study View) Cancer studies chart filter refactoring #5031
Draft
dippindots
wants to merge
49
commits into
cBioPortal:clickhouse
Choose a base branch
from
dippindots:fix-11068
base: clickhouse
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust patient treatments and sample treatments to use new treatment-counts api endoint (clickhouse driven)
* Add rfc80 test generator UI and test runner
* fix production build after webpack.config changes
* fix has generation based on url * add back all endpoints
…ta bin counts filters (cBioPortal#4980)
…#4981) * add tests for sample lists counts and custom data filters * add tests for custom data bin counts --------- Co-authored-by: Bryan Lai <laib1@mskcc.org>
* improvements to apiTests reporting * add skips to validation, refine report * skip test * improve report * Move api e2e to backend
…n fails on label fields
* use original clickhouse request. don't repeat it * Add generic assay endpoints and disable cn segments tab
… on command line, fx treatment validation
* add assertResponse capability to clickhouse validator * fixed reporting for custom data
* add runner for validation of datadog logged traffic * use axios for validation ajax to normalize * get rid of specs
fix provision of column-store body add public.js to validate data dog csv
@dippindots just wanted to make sure you saw the above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR