Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mutations Lollipop Tool Tip Info to await promise before retrieving patient counts #5033

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

haynescd
Copy link
Contributor

Mutation tab failed when attempting to grab filteredPatients promise before data was available.

@haynescd haynescd added the bug label Oct 25, 2024
@haynescd haynescd requested review from alisman and inodb October 25, 2024 20:30
@haynescd haynescd self-assigned this Oct 25, 2024
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 8a3b8d5
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/671c04a8694a9c00082fa2e1
😎 Deploy Preview https://deploy-preview-5033.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haynescd haynescd force-pushed the Fix-Mutation-Tab-Bug branch from df95ea7 to 8a3b8d5 Compare October 25, 2024 20:50
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@inodb inodb changed the title 🐛 Update Mutations Lollipop Tool Tip Info to await on promise before attempting to grab patient counts Fix Mutations Lollipop Tool Tip Info to await promise before retrieving patient counts Oct 28, 2024
@inodb inodb merged commit 8d6511c into master Oct 28, 2024
12 of 15 checks passed
@inodb inodb deleted the Fix-Mutation-Tab-Bug branch October 28, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants