Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation message in ad chart interface causes dropdown to widen unpleasantly #10737

Closed
alisman opened this issue Apr 4, 2024 · 5 comments · Fixed by cBioPortal/cbioportal-frontend#4892
Assignees

Comments

@alisman
Copy link
Contributor

alisman commented Apr 4, 2024

Depending on the length of the name of the chart added, the dropdown is forced to open wider. It then suddently jumps back when message disappears. Perhaps we should simplify this by notifying user with a toast message:

image

image

@mhsh312
Copy link

mhsh312 commented Apr 12, 2024

How about defining a max-width for the confirmation message so that the message box increases in height extra text just goes to the next line?

@alisman
Copy link
Contributor Author

alisman commented Apr 12, 2024

@mhsh312 the menu as a whole needs to be flexible width. the confirmation message should always fill but never push out the menu. this should be possible with css. give it a shot! thanks!

@mhsh312
Copy link

mhsh312 commented Apr 12, 2024

@alisman so are you saying that when the message is too big and wants more space, the whole menu should grow out instead of just the message?

@alisman
Copy link
Contributor Author

alisman commented Apr 12, 2024 via email

@mhsh312
Copy link

mhsh312 commented Apr 12, 2024

Ok, makes sense. I will make some css changes to the SuccessBanner component and that should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants