Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PdbAnnotation API dependency #3159

Closed
onursumer opened this issue Sep 21, 2017 · 8 comments
Closed

PdbAnnotation API dependency #3159

onursumer opened this issue Sep 21, 2017 · 8 comments
Assignees
Labels

Comments

@onursumer
Copy link
Member

We cannot completely remove PdbAnnotation API yet, because we fetch PDB header data from there.

@jjgao
Copy link
Member

jjgao commented Sep 22, 2017

@onursumer is that because we cache the PDB header there? Is performance OK to not use cache?

@onursumer
Copy link
Member Author

@jjgao It is a little slow without the cache since we are querying multiple PDB chains for a single gene. Also if we always hit the PDB web service directly, we may end up having problems similar to the ones we have with PFAM web service. Maybe it is better to add another endpoint in genome nexus for this one too.

@jjgao
Copy link
Member

jjgao commented Sep 22, 2017

@onursumer good point.

@jjgao
Copy link
Member

jjgao commented Jan 8, 2018

@onursumer how's going with this one?

@onursumer
Copy link
Member Author

I think this is fully integrated into genome nexus by genome-nexus/genome-nexus#97

@jjgao
Copy link
Member

jjgao commented Jan 9, 2018

and we are using the genome-nexus end point in portal too?

@onursumer
Copy link
Member Author

@jjgao Looks like we are still using the old endpoint, not genome nexus yet. Do you think it is a good time to switch to genome nexus, or should we do this after releasing 1.11.0?

@jjgao
Copy link
Member

jjgao commented Jan 10, 2018

as discussed, hotfix later.

@onursumer onursumer self-assigned this Jan 16, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Apr 4, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Apr 4, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Apr 4, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Apr 4, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Apr 4, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Apr 16, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Apr 17, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Apr 30, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue May 1, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue May 1, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue May 11, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue May 14, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue May 21, 2018
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants