Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call next study view filter when no samples left #10035

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Do not call next study view filter when no samples left #10035

merged 1 commit into from
Feb 26, 2023

Conversation

pvannierop
Copy link
Contributor

Problem

Study View filter Appliers are called on empty lists. This results in errors in some of the Filters.

Solution

Do not call next filter when not needed.

@pvannierop pvannierop self-assigned this Feb 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pvannierop
Copy link
Contributor Author

Terminate Study View filter applier when not needed

1 similar comment
@pvannierop
Copy link
Contributor Author

Terminate Study View filter applier when not needed

dippindots
dippindots approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@dippindots dippindots merged commit d028ccf into master Feb 26, 2023
@dippindots dippindots added the bug label Mar 7, 2023
@dippindots dippindots deleted the pvannierop-patch-2 branch July 20, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dippindots dippindots dippindots approved these changes

Assignees

@pvannierop pvannierop

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvannierop @dippindots