Fix validator bug with DFS_STATUS error log message #10045
Conversation
pvannierop
force-pushed
the
pvannierop-patch-3
branch
from
5e0ecb1
to
0265c59
Compare
| @@ -2941,7 +2941,6 @@ def checkLine(self, data): | |||
| self.logger.error( | |||
| 'Value in DFS_STATUS column is not 0:DiseaseFree, ' | |||
| '1:Recurred/Progressed, 1:Recurred, 1:Progressed', | |||
There was a problem hiding this comment.
@pvannierop I think we should still keep these values recommendations, I was wondering if you delete the comma at the end of this line, will that fix the problem too?
| '1:Recurred/Progressed, 1:Recurred, 1:Progressed', | |
| '1:Recurred/Progressed, 1:Recurred, 1:Progressed,' |
There was a problem hiding this comment.
It is already there. The final message will state:
Value in DFS_STATUS column is not 0:DiseaseFree, 1:Recurred/Progressed, 1:Recurred, 1:Progressed
| @@ -2941,7 +2941,6 @@ def checkLine(self, data): | |||
| self.logger.error( | |||
| 'Value in DFS_STATUS column is not 0:DiseaseFree, ' | |||
| '1:Recurred/Progressed, 1:Recurred, 1:Progressed', | |||
| 'DiseaseFree, Recurred/Progressed, Recurred or Progressed', | |||
There was a problem hiding this comment.
@pvannierop I see, I was wondering why we delete DiseaseFree, Recurred/Progressed, Recurred or Progressed. Now I get it. You are right. We don't support formats like these DiseaseFree, Recurred/Progressed, Recurred or Progressed anymore, we only support values with the prefix 0 or 1. So we should delete this line.
Does not expect a second argument since there is no '%' in the message.
dippindots
force-pushed
the
pvannierop-patch-3
branch
from
0265c59
to
7ff7623
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Problem
The python validator throws a python error when there is a data-dependent error in the
DFS_STATUScolumn.Solution
This is caused by the passing of a f-string variable where there is no need for string replacement (no
%present in message string). Removal of the second argument corrects this problem.