Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support StudyViewMyBatisRepository integration tests #10213

Conversation

onursumer
Copy link
Member

  • Currently only mysql compatible sql syntax is supported
  • Clickhouse specific features like base64Encode function breaks the testing environment, need to investigate further for clickhouse compatiblity

@inodb
Copy link
Member

inodb commented Jun 7, 2023

Clickhouse specific features like base64Encode function breaks the testing environment, need to investigate further for clickhouse compatiblity

Just double checking - right now we are not using any of these clickhouse functions right?

@onursumer onursumer force-pushed the clickhouse-integration-test branch from 8fc7de4 to 7a778cc Compare June 14, 2023 01:34
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@onursumer onursumer merged commit 60a5146 into cBioPortal:demo-clickhouse-k8s Jun 26, 2023
@onursumer onursumer deleted the clickhouse-integration-test branch June 26, 2023 21:47
jagnathan pushed a commit to pughlab/cbioportal that referenced this pull request Nov 8, 2023
…nd mutated genes (cBioPortal#10213)

Co-authored-by: Bryan Lai <laib1@mskcc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants