Extract column store endpoints into StudyViewControllerColumnStore #10245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onursumer
approved these changes
Jun 28, 2023
web/src/main/java/org/cbioportal/web/columnstore/StudyViewControllerColumnStore.java
Outdated
Show resolved
Hide resolved
| @@ -127,7 +128,7 @@ public class InvolvedCancerStudyExtractorInterceptor extends HandlerInterceptorA | |||
| if (!request.getMethod().equals("POST")) { | |||
| return true; // no attribute extraction needed because all user supplied filter objects are in POST requests | |||
| } | |||
| String requestPathInfo = request.getPathInfo(); | |||
| String requestPathInfo = StringUtils.removeStart(request.getPathInfo(), "/column-store"); | |||
There was a problem hiding this comment.
or we can just do this if we want to avoid using a 3rd party utility class.
Suggested change
| String requestPathInfo = StringUtils.removeStart(request.getPathInfo(), "/column-store"); | |
| String requestPathInfo = request.getPathInfo().replaceFirst("/column-store", ""); |
|
Kudos, SonarCloud Quality Gate passed! |
jagnathan
pushed a commit
to pughlab/cbioportal
that referenced
this pull request
Nov 8, 2023
…BioPortal#10245) * Extract column store endpoints into StudyViewControllerColumnStore * rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.