-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic assay binary types #10335
Generic assay binary types #10335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Djokovic0311 Just one comment about this, it should be an easy fix
private static final String[] posTypeList = {"true", "yes"}; | ||
private static final String[] negTypeList = {"false", "no"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about doing this, so we can avoid doing the conversion every time?
private static final String[] posTypeList = {"true", "yes"}; | |
private static final String[] negTypeList = {"false", "no"}; | |
private static final List<String> posTypeList = Arrays.asList("true", "yes"); | |
private static final List<String> negTypeList = Arrays.asList("false", "no"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Kudos, SonarCloud Quality Gate passed! 0 Bugs 0.0% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
* update possible valid binary types * Update ExpressionEnrichmentUtil.java * modify postypelist datatype
This pr is an enhancement of previous one inspired by one recent data sample. #10303 Add other allowed values for generic assay binary data. Now it supports both "yes" and "true" for pos samples while "no" and "false" for neg samples.
Could you please have a look at this pr? @dippindots @fuzhaoyuan Any suggestions or modifications are welcome!