Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unit Tests in Web Module #10371

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

haynescd
Copy link
Collaborator

@haynescd haynescd commented Sep 6, 2023

No description provided.

@@ -39,6 +39,7 @@

@InternalApi
@RestController
@RequestMapping("/api")
Copy link
Member

@inodb inodb Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there's a way to configure this for all API Controllers or e.g. InternalApi and PublicApi groups that might be better but no worries if not

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

if there's a way to configure the /api prefix for all API Controllers or e.g. InternalApi and PublicApi groups that might be cleaner but no worries if not

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@inodb inodb merged commit eedd9c6 into demo-rfc72 Sep 7, 2023
9 of 14 checks passed
@haynescd haynescd deleted the feature/ch/Update-Web-Module-Tests branch February 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants