Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Survival Data Endpoint for Dynamic Kaplan-Meier Curve #10774

Merged
merged 16 commits into from
Jun 12, 2024
Merged

New Survival Data Endpoint for Dynamic Kaplan-Meier Curve #10774

merged 16 commits into from
Jun 12, 2024

Conversation

7xuanlu
Copy link
Contributor

@7xuanlu 7xuanlu commented May 1, 2024 •
edited
Loading

Address issue Dynamic KM Plot and RFC 36
Frontend PR: cBioPortal/cbioportal-frontend#4900
This backend PR aims to add a new survival data api endpoint that supports customizable Dynamic Kaplan-Meier plot.

  • Support survival analysis with new api endpoint /survival-data/fetch
  • Add censored events along with start events and end events
  • Make clinical event configurable for each organization
  • Get clinical timeline events by filtering on a list of clinical events

@7xuanlu 7xuanlu requested review from alisman and kalletlak May 1, 2024 16:38
@7xuanlu 7xuanlu self-assigned this May 1, 2024
JREastonMarks
JREastonMarks suggested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@JREastonMarks JREastonMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@7xuanlu Before it is review please address the issues that SonarCloud found:

https://sonarcloud.io/dashboard?id=cBioPortal_cbioportal&pullRequest=10774

Thanks

@7xuanlu
Copy link
Contributor Author

7xuanlu commented May 3, 2024

@7xuanlu Before it is review please address the issues that SonarCloud found:

https://sonarcloud.io/dashboard?id=cBioPortal_cbioportal&pullRequest=10774

Thanks

I'm on this

@7xuanlu 7xuanlu force-pushed the fix-10375 branch 2 times, most recently from cfbbd00 to 5e66178 Compare May 10, 2024 16:10
@7xuanlu 7xuanlu requested a review from dippindots May 17, 2024 20:03
JREastonMarks
JREastonMarks approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@JREastonMarks JREastonMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job on the pass through.

haynescd
haynescd requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just address the new Sonar Cloud issues and its good

src/test/resources/logback.xml Outdated Show resolved Hide resolved
@haynescd
Copy link
Collaborator

Good job!!! @7xuanlu

haynescd
haynescd approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alisman alisman merged commit 52cbbcf into master Jun 12, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JREastonMarks JREastonMarks JREastonMarks approved these changes

@haynescd haynescd haynescd approved these changes

@alisman alisman Awaiting requested review from alisman

@kalletlak kalletlak Awaiting requested review from kalletlak

@dippindots dippindots Awaiting requested review from dippindots

Assignees

@7xuanlu 7xuanlu

Labels
api feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@7xuanlu @haynescd @JREastonMarks @alisman @kalletlak @qlu-cls