Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mutation-data-count API sync issue #10777

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix mutation-data-count API sync issue #10777

merged 1 commit into from
May 3, 2024

Conversation

7xuanlu
Copy link
Contributor

@7xuanlu 7xuanlu commented May 2, 2024 •
edited by inodb
Loading

Fix Swagger schema response

@7xuanlu 7xuanlu requested review from alisman and JREastonMarks May 2, 2024 20:47
@7xuanlu 7xuanlu self-assigned this May 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

JREastonMarks
JREastonMarks approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@JREastonMarks JREastonMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
May not be a bad idea to do a once over the API endpoints to make sure that this isn't the only one that needs correction.

@inodb inodb merged commit 92bf128 into master May 3, 2024
19 of 20 checks passed
@inodb inodb deleted the fix-mutation-api-doc branch May 3, 2024 15:03
@inodb inodb mentioned this pull request May 3, 2024
Closed
1 task
@inodb
Copy link
Member

inodb commented May 3, 2024

@7xuanlu Thanks for the fix! Could you do a pass on the other API endpoints as well as Jeremy proposed? Thanks so much!

@alisman alisman mentioned this pull request May 3, 2024
Merged
@7xuanlu
Copy link
Contributor Author

7xuanlu commented May 3, 2024

@7xuanlu Thanks for the fix! Could you do a pass on the other API endpoints as well as Jeremy proposed? Thanks so much!
Sure, I can hop on those. Let's just focus on endpoints whose return type is a list of an array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JREastonMarks JREastonMarks JREastonMarks approved these changes

@alisman alisman Awaiting requested review from alisman

Assignees

@7xuanlu 7xuanlu

Labels
api bug documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@7xuanlu @inodb @JREastonMarks @qlu-cls