Implement custom-data filtering #10827
Conversation
gblaih
force-pushed
the
demo-rfc80-poc-custom-data-bin-counts
branch
from
9e89e1d
to
462315d
Compare
| List<String> studyIds = new ArrayList<>(); | ||
| List<String> sampleIds = new ArrayList<>(); | ||
| studyViewFilterUtil.extractStudyAndSampleIds(studyViewFilter.getSampleIdentifiers(), studyIds, sampleIds); | ||
| sampleIdentifiers = sampleService.fetchSamples(studyIds, sampleIds, Projection.ID.name()).stream() |
There was a problem hiding this comment.
is this already handled in clickhouse and will result be same if we just wait to apply it there
gblaih
force-pushed
the
demo-rfc80-poc-custom-data-bin-counts
branch
from
eae97c9
to
de7677a
Compare
gblaih
force-pushed
the
demo-rfc80-poc-custom-data-bin-counts
branch
from
21cb701
to
694f149
Compare
| @@ -419,5 +419,37 @@ public ResponseEntity<SampleTreatmentReport> fetchSampleTreatmentCounts( | |||
| return new ResponseEntity<>(studyViewColumnarService.getSampleTreatmentReport(interceptedStudyViewFilter), | |||
| HttpStatus.OK); | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@gblaih should this be commented out?
| @@ -66,6 +66,45 @@ | |||
| '${sampleIdentifier.studyId}_${sampleIdentifier.sampleId}' | |||
| </foreach> | |||
| </if> | |||
| <if test="studyViewFilter.customDataFilters != null and !studyViewFilter.customDataFilters.isEmpty() and customDataSamples != null"> | |||
There was a problem hiding this comment.
i'm not sure i understand how this customDataFilters collection (which seems to be a member of the studyViewFilter) maps back to the extracted customDataFilters which has been added as an extra parameter to the mapper methods.
|
@haynescd @gblaih, as I discussed with Bryan, I would like to pursue a way to avoid passing customDataSamples through to all the methods. This strikes me as something that should be dealt with using interception. I prospose the following: we change the StudyViewFilter type to add a collection of custom data. The intereceptor invokes We might want to consider extending or wrapping StudyViewFilter if we feel that this collection of customData is not native to a "filter object". |
haynescd
force-pushed
the
demo-rfc80-poc-custom-data-bin-counts
branch
from
4da8b3b
to
fb3da66
Compare
…ql to account for NAs
…or custom data filtering
haynescd
force-pushed
the
demo-rfc80-poc-custom-data-bin-counts
branch
from
04a6427
to
fa3c45d
Compare
|
gblaih
changed the title
No description provided.