RFC87: updated application.properties example and documentation so works in default docker config #10944
Conversation
…ic_service property list
- changed example to use absolute path based on default docker config, since classpath: isn't supported - updated documentation - added TODO on readFile() method
|
Putting this back in draft mode, since the instructions may not work as is for private instances. ISSUETurns out that, at least for the public instance, the docker container uses the "/docker/web/Dockerfile" configuration which deploys everything as an app.jar. So readFile() will fail, since it looks for loose files on the filesystem. Note: Local development instructions use the "/docker/web-and-data/Dockerfile" configuration which deploys the directory structure as loose files, which is why it works in testing. OPTIONSMost likely, either of the following will solve it: A) readFile() needs to be updated to be able to load using "classpath;" syntax, which appears to be the intent of the documentation/examples. See getResourceStream() for an example of using the ClassLoader, which should work for the app.jar. Then the original syntax should work: B) config files like this need to be deployed to be loose on the server (outside the app.jar). For example, modifying /docker/web/Dockerfile like this: then this syntax works |
…th by leveraging spring ResourceUtils
|
closing - going to replace with new PR that fixes the issue |
Updated the application.properties example and download_custom_buttons_json documentation to a configuration that will work in the default docker config. Specifically, changed from using "classpath:" to
Explanation
It seems that the "classpath:" syntax doesn't work with the readFile() method used by FrontendProperties. This commit changes the example to use the absolute path that matches how the default docker config is set (files installed to /cbioportal-webapp/).
Further Improvements
Ideally, either a relative path or "classpath:" would work for the application.properties. Then all configurations would work with a copy/paste of the reference.
Checks
Tested on local docker running 6.016.
Notify reviewers
@alisman