Improve numerical clinical data filter #10951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onursumer
changed the title
onursumer
force-pushed
the
improve-numerical-clinical-data-filter
branch
from
77764d6
to
24253fb
Compare
alisman
reviewed
Aug 20, 2024
| '>6' to 6.00..1... | ||
| '<6' to 5.99..9... | ||
| --> | ||
| <sql id="castStringValueToFloat"> |
There was a problem hiding this comment.
@onursumer @haynescd if it turns out this is a performance killer, we could precompute this right?
There was a problem hiding this comment.
Yea, you could do this when you create the table
onursumer
force-pushed
the
improve-numerical-clinical-data-filter
branch
from
24253fb
to
14626b2
Compare
onursumer
force-pushed
the
improve-numerical-clinical-data-filter
branch
from
14626b2
to
b628e38
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/rfc80-team#32
Fixes cBioPortal/rfc80-team#44
Handle numerical clinical data values such as
<18,>90,<=3,>=9when range filtering.This PR also improves the numerical value matching. Previously only positive integers could be matched, with this PR negative values as well as decimal numbers are also matched.