Genomic and Generic Assay bin counts endpoints #10964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippindots
force-pushed
the
genomic-and-generic-assay-bin-counts-endpoints-clickhouse-rebase
branch
from
692f34c
to
dcaa432
Compare
dippindots
force-pushed
the
genomic-and-generic-assay-bin-counts-endpoints-clickhouse-rebase
branch
from
99f7e96
to
415cb1a
Compare
|
@dippindots Can you address the Sonar issues |
haynescd
requested changes
Aug 29, 2024
src/main/resources/org/cbioportal/persistence/mybatisclickhouse/StudyViewMapper.xml
Outdated
Show resolved
Hide resolved
src/main/java/org/cbioportal/web/parameter/CategorizedClinicalDataCountFilter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cbioportal/service/impl/StudyViewColumnarServiceImpl.java
Outdated
Show resolved
Hide resolved
|
@haynescd Thanks for the review, I will make changes accordingly, I looked at the |
haynescd
force-pushed
the
genomic-and-generic-assay-bin-counts-endpoints-clickhouse-rebase
branch
from
030e7f1
to
b204683
Compare
haynescd
reviewed
Sep 11, 2024
| @@ -206,7 +206,8 @@ CREATE TABLE genetic_profile | |||
| description String, | |||
| show_profile_in_analysis_tab Int32, | |||
| generic_assay_type Nullable(String), | |||
| cancer_study_id Int32 | |||
| cancer_study_id Int32, | |||
| patient_level Nullable(Int32), | |||
There was a problem hiding this comment.
Does this need to be nullable? In clickhouse it creates a separate Nullable column to handle this? Just want to make sure because it will increase the data foot print
dippindots
force-pushed
the
genomic-and-generic-assay-bin-counts-endpoints-clickhouse-rebase
branch
from
36916d7
to
8c0f82b
Compare
|
haynescd
approved these changes
Sep 11, 2024
dippindots
deleted the
genomic-and-generic-assay-bin-counts-endpoints-clickhouse-rebase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's inside this pull request:
genetic_alteration_numerical_derived, we should be able to merge this one withgenetic_alteration_cna_derivedlater, these two tables has similar structure, only one column' type is differentgeneric_assay_data_derivedTODO List:
genomic-data-bin-countsendpoint andgeneric-assay-bin-countsbecause of the way we store those data. We are storing data as a sampl)Related frontend:
cBioPortal/cbioportal-frontend#4988