Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update News images for RFC87 #10990

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Update News images for RFC87 #10990

merged 1 commit into from
Sep 23, 2024

Conversation

pappde
Copy link
Contributor

@pappde pappde commented Sep 13, 2024

Two updates to the existing news item:

  • added image of visualization
  • cropping data table image so easier to see location of button (especially in narrow panel)

Explanation: The original image was too subtle indicating where the new button was in the data table, and there was no display of the visualization.

Note: The total real estate occupied by the images is actually the same, since the original image was cropped to be half the size.

Screenshots

Original:
News2-Old

New:
News2-New

Notify reviewers

@jjgao

- adding image of visualization
- cropping data table image so easier to see location of button in narrow panel
@jjgao jjgao requested a review from alisman September 22, 2024 21:38
@alisman alisman merged commit 3d37309 into cBioPortal:master Sep 23, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants