Add samples field to custom filters to allow fetching samples without session #10998
+900
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gblaih
force-pushed
the
demo-rfc80-poc-custom-samples-field
branch
from
967693c
to
a3e3be0
Compare
junengineer
reviewed
Sep 22, 2024
| List<CustomSampleIdentifier> samples = filter.getSamples(); | ||
| return (samples != null) ? samples.stream() : Stream.empty(); | ||
| }) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
Suggested change
| .collect(Collectors.toList()); | |
| .toList(); |
junengineer
reviewed
Sep 22, 2024
Comment on lines
136
to
138
| List<CustomSampleIdentifier> customSampleIdentifiers = new ArrayList<>(); | ||
|
|
||
| customSampleIdentifiers.addAll(customSamplesFromProperty); |
There was a problem hiding this comment.
Suggested change
| List<CustomSampleIdentifier> customSampleIdentifiers = new ArrayList<>(); | |
| customSampleIdentifiers.addAll(customSamplesFromProperty); | |
| List<CustomSampleIdentifier> customSampleIdentifiers = new ArrayList<>(customSamplesFromProperty); |
|
@gblaih please replace |
|
@gblaih address the sonar cloud issues as well |
haynescd
reviewed
Sep 24, 2024
Comment on lines
260
to
264
| if (rangeValue != null) { | ||
| if (ranges.stream().anyMatch(r -> r.encloses(rangeValue))) { | ||
| count++; | ||
| } | ||
| } |
There was a problem hiding this comment.
this can be simplified &&
gblaih
force-pushed
the
demo-rfc80-poc-custom-samples-field
branch
from
d586273
to
317412b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10982