Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused noauthsessionservice property #11169

Conversation

nbentoneves
Copy link
Contributor

@nbentoneves nbentoneves commented Nov 7, 2024

Fix #10799

Describe changes proposed in this pull request:

  • Update README.md to use -Dauthenticate=false
  • Remove noauthsessionservice from ApiSecurityConfig.java

Note:
The noauthsessionservice is still reference in session-service-working.md file https://github.com/cBioPortal/cbioportal/blob/master/docs/development/session-service-working.md#21-configuring-session-service. What would be the alternative property for noauthsessionservice?

Checks

@nbentoneves nbentoneves marked this pull request as draft November 7, 2024 14:18
@nbentoneves nbentoneves marked this pull request as ready for review November 7, 2024 14:18
@inodb inodb requested a review from haynescd November 14, 2024 22:44
@inodb inodb added the cleanup label Nov 14, 2024
Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inodb
Copy link
Member

inodb commented Nov 15, 2024

@nbentoneves Good catch also on this:

Note:
The noauthsessionservice is still reference in session-service-working.md file master/docs/development/session-service-working.md#21-configuring-session-service. What would be the alternative property for noauthsessionservice?

I just removed that warning b/c it doesn't seem to be necessary anymore

@inodb inodb merged commit d2bb276 into cBioPortal:master Nov 15, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend dev documentation does not boot portal
3 participants