Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update for unauthorized studies portal prop #9272

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

dianab0
Copy link
Contributor

@dianab0 dianab0 commented Jan 31, 2022

Updated portal property reference docs for the configuration of a global message for unauthorized studies.

This docs update is related to PR cBioPortal/cbioportal-frontend#4138

docs/portal.properties-Reference.md Outdated Show resolved Hide resolved
docs/portal.properties-Reference.md Outdated Show resolved Hide resolved
@dianab0
Copy link
Contributor Author

dianab0 commented Feb 1, 2022

Added changes from review under the same commit

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianab0 Looks good to me, Are the related changes already merged? Could you mention that pr in the description if it's already merged?

@dianab0
Copy link
Contributor Author

dianab0 commented Feb 5, 2022

@dippindots , thank you, no, the PR containing related changes wasn't merged yet cBioPortal/cbioportal-frontend#4138

Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dianab0
Copy link
Contributor Author

dianab0 commented Feb 16, 2022

@dippindots , the PR containing related changes (cBioPortal/cbioportal-frontend#4171) has been merged, so this one is ready to be merged as well. Thank you.

@dippindots dippindots merged commit 0a3a7a9 into cBioPortal:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants