Implement Session Service 'user settings' for Results View #9450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasLee
force-pushed
the
oncoprint-config-user-session
branch
from
961ee90
to
ccc979d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
pvannierop
changed the title
onursumer
reviewed
Jul 11, 2022
| HttpServletResponse response) throws IOException { | ||
| private void updatedPageSettingSession( | ||
| PageSettings pageSettings, | ||
| @RequestBody PageSettingsData body, |
There was a problem hiding this comment.
maybe name the variable pageSettings instead of body?
There was a problem hiding this comment.
The variable pageSettings is already declared on the previous line
web/src/main/java/org/cbioportal/web/parameter/PageSettingsData.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/cbioportal/web/parameter/ResultPageSettings.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/cbioportal/web/parameter/SessionPage.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/cbioportal/web/SessionServiceController.java
Outdated
Show resolved
Hide resolved
dippindots
reviewed
Jul 13, 2022
web/src/main/java/org/cbioportal/web/SessionServiceController.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/cbioportal/web/parameter/ResultPageSettings.java
Outdated
Show resolved
Hide resolved
Luke-Sikina
approved these changes
Jul 18, 2022
web/src/main/java/org/cbioportal/web/SessionServiceController.java
Outdated
Show resolved
Hide resolved
Yes, the frontend changes are proposed in PR #9450 . For now this only relates to storing the clinical tracks layout of Oncoprint. |
pvannierop
force-pushed
the
oncoprint-config-user-session
branch
from
546e532
to
e15f7c6
Compare
pvannierop
force-pushed
the
oncoprint-config-user-session
branch
from
e15f7c6
to
d408b38
Compare
Luke-Sikina
approved these changes
Jul 26, 2022
Rename result_view to results_view Update web/src/main/java/org/cbioportal/web/parameter/SessionPage.java Update web/src/main/java/org/cbioportal/web/parameter/ResultPageSettings.java Co-authored-by: Onur Sumer <s.onur.sumer@gmail.com>
- remove unused var - remove unthrown exception - make fields private & add getters setters
BasLee
force-pushed
the
oncoprint-config-user-session
branch
from
75e11f8
to
9e3dbaf
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dippindots
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will provide support in the cBioPortal backend to store user settings for Results View in Session Service. At the moment this is only done for user settings in Study View.
Changes:
results_viewtoSessionPagetypeResultsPageSettingscontaining result page configuration (at the moment onlyclinicallist)SessionPage-type toPageSettingsData-implementation usingSessionServiceController.pageTypeToDataPageSettingsData bodytoupdatedPageSettingSession