Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to API endpoints (SV, Generic Assay, Gene Panel) #9457

Merged

Conversation

jagnathan
Copy link
Collaborator

@jagnathan jagnathan commented Apr 12, 2022

Fix #9342

  • Changes to API endpoints - SV, Generic Assay, Gene Panel Info with reallocation and creation of new endpoints

  • Categorize APIs to Internal and External

  • Created data controllers for Gene Panel and Generic Assay

  • Added new GET endpoints for data controllers of Gene Panel and Generic Assay

  • Gene Panel Data controller

  1. /molecular-profiles/{molecularProfileId}/gene-panel-data/fetch
  2. /gene-panel-data/fetch
  • Generic Assay Meta controller
  1. /generic-assay-meta/{molecularProfileId}
  2. /generic-assay-meta/generic-assay/{genericAssayStableId}
  • Generic Assay Data controller
  1. /generic-assay-data/{molecularProfileId}/generic-assay/{genericAssayStableId}
  2. /generic_assay_data/{molecularProfileId}/fetch
  3. /generic_assay_data/fetch

Changes to API endpoints - SV, Generic Assay, Info
fix cBioPortal#9342 API endpoint changes ; Split Gene Panel into Meta and Data, Added Generic assay Data. Added tests for all.
Changes to API endpoints - SV, Generic Assay, Info
fix cBioPortal#9342 API endpoint changes ; Split Gene Panel into Meta and Data, Added Generic assay Data. Added tests for all.
@jagnathan jagnathan requested a review from inodb April 20, 2022 18:41
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 46 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jagnathan! I think some of these changes would require changes to the frontend as well right? Is there a PR for that yet?

@jagnathan
Copy link
Collaborator Author

Thanks @jagnathan! I think some of these changes would require changes to the frontend as well right? Is there a PR for that yet?

That will be a separate PR as it is only changing underscore _ to dash -

@inodb inodb added the api label May 11, 2022
@inodb inodb changed the title Fix 9342 api endpoint outstanding issues Backwards compatible updates to several endpoints (SV, Generic Assays, Gene Panel) May 11, 2022
@inodb inodb changed the title Backwards compatible updates to several endpoints (SV, Generic Assays, Gene Panel) Backwards compatible updates to several API endpoints May 11, 2022
@inodb inodb changed the title Backwards compatible updates to several API endpoints Renaming and addition of to several API endpoints (SV, Generic Assay, Gene Panel) May 11, 2022
@inodb inodb changed the title Renaming and addition of to several API endpoints (SV, Generic Assay, Gene Panel) Updates to API endpoints (SV, Generic Assay, Gene Panel) May 11, 2022
@inodb inodb merged commit 81b86a5 into cBioPortal:master May 11, 2022
jagnathan added a commit to pughlab/cbioportal that referenced this pull request Nov 8, 2023
…9457)

Fix cBioPortal#9342
- Changes to API endpoints - SV, Generic Assay, Gene Panel Info with reallocation and creation of new endpoints
- Categorize APIs to Internal and External
- Created data controllers for Gene Panel and Generic Assay
- Added new GET endpoints for data controllers of Gene Panel and Generic Assay

- Gene Panel Data controller 
1. /molecular-profiles/{molecularProfileId}/gene-panel-data/fetch
2. /gene-panel-data/fetch
- Generic Assay Meta controller
1. /generic-assay-meta/{molecularProfileId} 
2. /generic-assay-meta/generic-assay/{genericAssayStableId}
- Generic Assay Data controller
1. /generic-assay-data/{molecularProfileId}/generic-assay/{genericAssayStableId}
2. /generic_assay_data/{molecularProfileId}/fetch
3. /generic_assay_data/fetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API endpoint outstanding issues
2 participants