-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default logging level, document Logback config #9537
Conversation
- update poms with new excludes - update main pom to copy logback config - update README with logback info
5893c43
to
5b09b0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, although we should not rely on me alone. My understanding now is that a switch in logging was made months ago to logback configuration, but the configuration files in the build setup (pom.xml) fell out of sync. This PR seems to give updated guidance to deployers on how to configure logback (dropping guidance on log4j config files), and has the logic for including the logback.xml-EXAMPLE file in the build when the user does not provide a custom logback.xml file of their own.
The fact that the pom.xml reference to logback.xml is in an <exclude> element is a little confusing to me --- because I think we want them included during build. But maybe this is to exclude them from getting bundled into sub-modules as they are deployed at the root level.
👍
Kudos, SonarCloud Quality Gate passed! |
Changed the title and description slightly b/c I think the critical piece is that this changes the default Docker setup to no longer do debug logging by default. Feel free to change tho |
- update poms with new excludes - update main pom to copy logback config - update README with logback info
- update poms with new excludes - update main pom to copy logback config - update README with logback info
- update poms with new excludes - update main pom to copy logback config - update README with logback info
- update poms with new excludes - update main pom to copy logback config - update README with logback info
- update poms with new excludes - update main pom to copy logback config - update README with logback info
- update poms with new excludes - update main pom to copy logback config - update README with logback info
Fix #9538. Describe changes proposed in this pull request: