Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default logging level, document Logback config #9537

Merged
merged 3 commits into from
May 16, 2022

Conversation

Luke-Sikina
Copy link
Member

@Luke-Sikina Luke-Sikina commented May 13, 2022

Fix #9538. Describe changes proposed in this pull request:

  • Use the provided logback EXAMPLE file by default. This changes the current default of DEBUG logging everything which caused performance issues in portals with authentication. This was introduced in v4.0.2.
  • update poms with new excludes
  • update main pom to copy logback config
  • update README with logback info

- update poms with new excludes
- update main pom to copy logback config
- update README with logback info
Copy link
Contributor

@sheridancbio sheridancbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, although we should not rely on me alone. My understanding now is that a switch in logging was made months ago to logback configuration, but the configuration files in the build setup (pom.xml) fell out of sync. This PR seems to give updated guidance to deployers on how to configure logback (dropping guidance on log4j config files), and has the logic for including the logback.xml-EXAMPLE file in the build when the user does not provide a custom logback.xml file of their own.

The fact that the pom.xml reference to logback.xml is in an <exclude> element is a little confusing to me --- because I think we want them included during build. But maybe this is to exclude them from getting bundled into sub-modules as they are deployed at the root level.

👍

@inodb inodb merged commit 633c657 into cBioPortal:master May 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@inodb inodb changed the title Document Logback config, improve usage Change default logging, document Logback config May 16, 2022
@inodb inodb changed the title Change default logging, document Logback config Change default logging level, document Logback config May 16, 2022
@inodb
Copy link
Member

inodb commented May 16, 2022

Changed the title and description slightly b/c I think the critical piece is that this changes the default Docker setup to no longer do debug logging by default. Feel free to change tho

sheridancbio pushed a commit that referenced this pull request Jun 28, 2022
- update poms with new excludes
- update main pom to copy logback config
- update README with logback info
sheridancbio pushed a commit that referenced this pull request Jun 29, 2022
- update poms with new excludes
- update main pom to copy logback config
- update README with logback info
sheridancbio pushed a commit that referenced this pull request Jul 6, 2022
- update poms with new excludes
- update main pom to copy logback config
- update README with logback info
sheridancbio pushed a commit that referenced this pull request Oct 6, 2022
- update poms with new excludes
- update main pom to copy logback config
- update README with logback info
sheridancbio pushed a commit that referenced this pull request Oct 10, 2022
- update poms with new excludes
- update main pom to copy logback config
- update README with logback info
jagnathan pushed a commit to pughlab/cbioportal that referenced this pull request Nov 8, 2023
- update poms with new excludes
- update main pom to copy logback config
- update README with logback info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logback config doesn't configure app if left in current spot
4 participants