This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Germline mutation #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the general idea which was to have as much state as possible maintained in the main, keeping the rest of the code as pure as possible. add the invert_array function to utils.
Specifically, more on the gulp build options. Question: where are we going to host the latest build?
Inspired by writing documentation. Don't force users to select or setup containers. They can just use strings that select for divs.
Create a main script with clean programmer API.
Bring README up to date.
- This created a bug when you resorted oncoprint before inserting the row. - The top level container, the parent of the table, is what has the freshest data. Nothing wrong with that. What happens below with the nested selections and whatnot is a different issue. And yet more TODOs
…nsert data, decorate it in a couple of ways, and resort it. rendering strategies still not great, i.e. when we add a new track for example should we be rerendering everything?
…ule and deleting a comment
… well as adjusting some config accesses
…ng visual settings
Change 'D3SVGRuleSet' to 'D3SVGRuleset' ('S' => 's') because
it's not a set of rules, its a ruleset.
Also flattened ordered rule list that a Ruleset spits out.
Added 'D3SVGRuleset#apply' for ease of use/modularity Factored out percentage conversion into 'D3SVGRule#_toLocalCoords'. This may still not be the right place for it... Removed 'D3SVGRule#filterData' and put its functionality into 'D3SVGRule#apply' Changed 'id_member' to 'datum_id' which is now a function that takes a datum and returns its id. This takes the place of what was 'D3SVGCellRenderer#data_key' Moved the binding of the event cellRenderer.updateCells() into the cellRenderer instead of Track where it was. Changed 'renderX' to 'init' in track and cell renderer
Handling config passing better with ReadOnlyObject, which completes the transition to eliminating circular dependencies. Also, implemented first template: categorical_color
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
…acement Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
(1) Legend rules now arranged in alphabetical order of label, with no-label appearing first. (2) New API method setTrackGroupLegendOrder, to set order of track legends by track group Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Add a track parameter that allows tracks to be annotated with a hyperlink, which will appear as the first line of the track label's tooltip if specified. Follow the example from cell view tooltips on how to make the tooltips mouse-navigable.
Allow a pre-escaped HTML version of a track name to be set as a property on String objects given as the label of a track, to include special characters.
Make the Oncoprint aware of tracks that are added to the Oncoprint as the expansion of other tracks, by: - making the Oncoprint model class recognise a track parameter specifying that the track being added is the expansion of another track; - adding an option in the track options menu, to remove expansion tracks associated with an expanded track - making the Oncoprint model class recognise a track parameter holding a callback to perform any actions involved in expanding the track; - adding an option to the track options menu to call the expansion callback; and - making the Oncoprint model class recognise a track parameter holding a function to customise the text of the 'expand' menu option Tracks marked as another track's expansion will remain grouped underneath that track, and tracks on the same level as the parent will not move into that group; the 'effective track group' of tracks they can move around includes only tracks on the same level.
Rather than appending it to the bottom of the track group, an expansion track should be inserted into the track group immediately underneath (the last pre-existing expansion of) its parent track.
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
…rder defined Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Commit 6310fa4 introduced an option to specify an HTML string for custom rendering of the label in the tooltip, but it required passing the label as a non-primitive String object. Since these may not behave identical to plain strings in all contexts, this may lead to bugs in the long run, and it's safer to remove this part of the API right away and simply add another track param instead.
rnugraha
force-pushed
the
germline-mutation
branch
from
a27da50 to
4739bc4
Compare
|
I messed up the git history, I'll create new PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has dependency on cBioPortal/cbioportal-frontend#913
Before
After