Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type erase the receive-message and receive-event systems #775

Merged
merged 4 commits into from
Jan 5, 2025

Conversation

cBournhonesque
Copy link
Owner

Two main benefits:

  • we only have one read_messages system instead of one system per message-type. There is an overhead in having many systems running (see Optimize Event Updates bevyengine/bevy#12936)
  • the read_events/read_messages logic is unified

Fixes #536

@cBournhonesque cBournhonesque merged commit 6026831 into main Jan 5, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type erase message events?
1 participant