Spaceships predicted despawn behaviour #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spaceships example, I notice this behaviour:
EntityMut::remove::<server.Replicate>().despawn()on the serverEntityMut::despawn()on the client.I don't think this behavior is correct
EntityMut.remove::<server.Replicate>().despawn()would still send a ReplicateDespawn message. To avoid sending the message you need do toEntityMut::remove<Replicating>().despawn(). It's best to use the provided commandcommands.despawn_without_replication()Also we want the despawn to be replicated from the server to guarantee that the client/server behavior stay in sync!
So what we actually want is to do a normal despawn on the server, and to do a predicted_despawn on the client.
(For a predicted_despawn, I remove all components on the entity but I still keep the entity and the PredictionHistory, in case the predicted_despawn gets reverted and I need to re-add all the components again. It might be possible to avoid special casing the prediction despawn: #793)